-
-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for npm overrides #850
Conversation
Codecov Report
@@ Coverage Diff @@
## master #850 +/- ##
==========================================
+ Coverage 94.36% 94.37% +0.01%
==========================================
Files 17 17
Lines 550 551 +1
==========================================
+ Hits 519 520 +1
Misses 31 31
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Thanks! Can you also add something to the readme about this feature? |
@kategengler yes that would make a lot of sense if I did that 😂 I'm working on this live on my stream so I guess I just overlooked it 🙃 I've added them now 👍 |
Til better fix with ember-cli/ember-try#850
59514eb
to
81beb54
Compare
Thank you! |
This PR is supposed to help with the issue that is described in emberjs/ember-render-modifiers#64
Essentially npm thinks that ranges shouldn't be satisfied if you are using pre-releases. You can overcome this if you use an
overrides
in npm which works in a very similar way to yarn resolutions.The issue is that if you provide an
overrides
config to ember-try it will just ignore it:This PR implements npm overrides in much the same way as yarn resolutions 👍 in fact I copy and pasted all of the resolutions tests and just changed resolutions to overrides in most cases 😂